fix(cli): Ensure home directory exists when writing contexts#3069
Open
pauliyobo wants to merge 2 commits intoapache:masterfrom
Open
fix(cli): Ensure home directory exists when writing contexts#3069pauliyobo wants to merge 2 commits intoapache:masterfrom
pauliyobo wants to merge 2 commits intoapache:masterfrom
Conversation
pauliyobo
force-pushed
the
fix/issue-3030
branch
from
413bf94 to
5687952
Compare
atharvalade
suggested changes
Apr 10, 2026
pauliyobo
force-pushed
the
fix/issue-3030
branch
from
8f0ee9a to
ca7940b
Compare
Author
|
Hello |
atharvalade
approved these changes
Apr 13, 2026
Contributor
atharvalade
left a comment
atharvalade
left a comment
There was a problem hiding this comment.
thanks for fixing it! lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3030
Rationale
What changed?
When
write_contexts()orwrite_active_context()are called, they directly attempt to write the file without ensuring that the iggy home directory exists. This causes issues like #3030To fix this,
ensure_iggy_home()is called in both methods prior to file creation.Local Execution
Passed, and precommit ran
PS: I had to add writeable to the typos toml configuration since it would kep being flagged. Not sure if this could cause issues when a genuine spelling mistake happens.